CADC-13844 - refactor to #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urce query limits
… the data label earlier
andamian
approved these changes
Dec 24, 2024
| @@ -1224,8 +1240,21 @@ def _remove_processing_detritus(values, obs_id): | |||
|
|
|||
|
|
|||
| class Bhros(GeminiMapping): | |||
| def __init__(self, storage_name, headers, lookup, instrument, clients, observable, observation, config): | |||
| super().__init__(storage_name, headers, lookup, instrument, clients, observable, observation, config) | |||
| def __init__( | |||
There was a problem hiding this comment.
Maybe I'm missing something, but looks like this __init__ is not necessary since by default the super class one is called anyway. Comment applies to other classes in this file.
| def _mock_get_head(file_id): | ||
| return _mock_headers(file_id, file_id) | ||
|
|
||
|
|
||
| from caom2 import Algorithm, SimpleObservation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour that got changed:
The refactoring that is in progress (incremental mode only for now):
2. Use a RunnerMeta class, with a StorageName instance, instead of the StateRunnerMeta class. Using the StateRunnerMeta class resulted in throwing away some useful metadata, that then needed to be reacquired from either archive.gemini.edu or from header files, so this pull request stops doing that, for incremental execution only.
3. Remove the need for MetadataReader specializations. Without those classes, the FileInfo and header from the MetadataReader class has been moved to the StorageName class. The MetadataReader pattern required explicit
clean_upandresetcalls. This pull request removes the needs for those extra calls, and the resulting wide variations in memory usage.4. Remove the need for the name_build_composable.py classes/specializations. This can be done as a result of (2).